Ensure compatibility with Node.js 10 and 12 (Fix missed one)#33
Ensure compatibility with Node.js 10 and 12 (Fix missed one)#33lovell merged 1 commit intolovell:mainfrom
Conversation
Continue from lovell#30
|
Thank you very much for the PR, and apologies for not noticing this usage when reviewing #30 I'd like to clarify that this package did not cause a problem in Deno, merely exposed that it had not yet fully implemented the Node.js |
|
Thank you very much — this was really helpful! Of course, considering the complexity of Node’s evolving specifications, I think it’s understandable that issues like this can happen (especially since this is a Node library, and Deno-related matters are technically out of scope). Once this change is released in a patch, at least the applications I maintain will automatically be fixed, so I truly appreciate it. |
|
v2.1.2 now available, thank you. |
2 participants
Continuing from #30:
It seems that one
fs.close()line still remains.In my case, commit 4d6eafec caused denoland/deno#30718, so this PR should fix it and may also help users affected by that issue on Deno.